[m-rev.] for review: print message when launching xml browser from mdb

Ian MacLarty maclarty at cs.mu.OZ.AU
Thu Feb 3 17:05:43 AEDT 2005


On Wed, Feb 02, 2005 at 03:03:25PM +1100, Julien Fischer wrote:
> 
> On Wed, 2 Feb 2005, Ian MacLarty wrote:
> 
> > For review by anyone.
> >
> > Estimated hours taken: 0.5
> > Branches: both
> >
> There are more than two branches, so I suggest main, release there.
> 
> > Print a message when saving a term to XML and launching the XML browser.
> > Do this because for largish terms the browser may take a while to open the XML
> > file.
> Presuambly, it's processing rather than opening the XML file that takes
> time.

By "open" I mean "open, parse and display on the screen" - i.e. "open" as the 
browser user would understand it - i.e. by clicking file/open.

> 
> The log message should mention the reason for this change: namely
> that we don't want the user thinking somthing has gone wrong with
> their debugging session, just because the XML browser doesn't
> immediately begin.
> 

Fine.

> > Index: trace/mercury_trace_internal.c
> > ===================================================================
> > RCS file: /home/mercury1/repository/mercury/trace/mercury_trace_internal.c,v
> > retrieving revision 1.191
> > diff -u -r1.191 mercury_trace_internal.c
> > --- trace/mercury_trace_internal.c	1 Feb 2005 03:24:32 -0000	1.191
> > +++ trace/mercury_trace_internal.c	1 Feb 2005 23:07:51 -0000
> > @@ -1284,6 +1284,8 @@
> >  MR_trace_save_and_invoke_xml_browser(MR_Word browser_term)
> >  {
> >      if (MR_xml_tmp_filename != NULL && (!MR_streq(MR_xml_tmp_filename, ""))) {
> > +        fprintf(MR_mdb_out, "Saving term to XML file...\n");
> > +        fflush(MR_mdb_out);
> >          MR_trace_save_term_xml(MR_xml_tmp_filename, browser_term);
> >      } else {
> >          fflush(MR_mdb_out);
> > @@ -1294,6 +1296,8 @@
> >      if (MR_xml_browser_command != NULL &&
> >          (!MR_streq(MR_xml_browser_command, "")))
> >      {
> > +        fprintf(MR_mdb_out, "Launching XML browser...\n");
> > +        fflush(MR_mdb_out);
> Perhaps that should be:
> 
> 	Launcing XML browser (this may take some time) ...
> 

Okay.

Ian.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list