[m-rev.] for review: fix problems with mmc --make

Peter Wang wangp at students.cs.mu.OZ.AU
Mon Dec 5 13:22:19 AEDT 2005

On 2005-12-02, Julien Fischer <juliensf at cs.mu.OZ.AU> wrote:
> > +:- pred shared_libraries_supported(bool::out, io::di, io::uo) is det.
> > +
> > +shared_libraries_supported(Supported, !IO) :-
> > +    globals__io_lookup_string_option(library_extension, LibExt, !IO),
> > +    globals__io_lookup_string_option(shared_library_extension, SharedLibExt,
> > +        !IO),
> > +    Supported = (if LibExt \= SharedLibExt then yes else no).
> > +
> This does not seem particularly robust.  I think a better approach here would
> be to have configure set a macro in mercury_conf.h (MR_HAVE_SHARED_LIB or
> something) and test that here.

Not sure what to do about it.  It seems like the standard way to test if
shared libraries are supported so I left it and added an XXX.

> I take it mmc --make doesn't always require .mh?  If so please mark
> that comment with an XXX and mention that if we ever phase out mmake
> we can get rid of this behaviour.


mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe

More information about the reviews mailing list