[m-rev.] for review: fix warnings on x86_64

Zoltan Somogyi zs at cs.mu.OZ.AU
Wed Aug 31 13:29:52 AEST 2005


On 31-Aug-2005, Mark Brown <mark at cs.mu.OZ.AU> wrote:
> Either the type of MR_PredFunc needs to be changed, or the comment in
> mdbcomp/prim_data.m that says "the code (in browser) assumes the
> representation is the same" should be changed, since the representation
> is not the same.  In any case, the meaning of "EXACTLY" should probably be
> clarified.

You want the comment to say that the representation of preds and funcs
is the same, while only the runtime has a representation of "neither".

> > > +** MR_Proc_Id is a union. The first alternative identifies ordinary
> > > +** procedures, while the second alternative identifies automatically generated
> > > +** unification, comparison and index procedures.  The third alternative
> > 
> > Should initialise precedures be included in this list?
> 
> I don't think so.

Yes, they should be included.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list