[m-rev.] for review: debugging infrastructure for the deep profiler

Julien Fischer juliensf at cs.mu.OZ.AU
Fri Apr 22 17:55:29 AEST 2005



On Fri, 22 Apr 2005, Zoltan Somogyi wrote:

> For review by Julien.
>
> Zoltan.
>
> Significantly enhance the infrastructure for debugging problems with the deep
> profiler by providing facilities for dumping out some of the main data
> structures. These were needed for my recent fix of mercury_deep_profiling.c
> in the runtime.
>
> There are no algorithmic changes in the non-debugging parts of the code.
>
> deep_profiler/dump.m:
> 	New module for containing predicates that dump data structures.
> 	The first draft was by Julien.
>
> deep_profiler/mdprof_dump.m:
> 	New program for dumping out the contents of Deep.data files.
> 	The first draft was by Julien.
>
> deep_profiler/startup.m:
> 	Provide a mechanism for dumping out the main data structures at three
> 	stages.
>
> deep_profiler/mdprof_cgi.m:
> deep_profiler/mdprof_test.m:
> 	Pass the options to startup to control these dumps.
>
> deep_profiler/measurements.m:
> 	Provide a mechanism for getting all the counts of a measurement at
> 	once.
>
> deep_profiler/array_util.m:
> 	Provide extra modes of some predicates for use in the other modules.
>
> deep_profiler/read_profile.m:
> 	Fix Julien's fix: handle init predicates as well as the other uci
> 	predicates.

Yes, I forgot about those - mainly because we don't use solver types
in the library so it wasn't an immediate problem.

>
> deep_profiler/profile.m:
> 	Reorder the arguments of predicates as required to enable the use
> 	of state variable notation in the callers.
>
> deep_profiler/*.m:
> 	Conform to the change in profile.m, and use state variable notation
> 	where this is advantageous.
>
> 	Convert some modules to four-space indentation where this eliminates
> 	excessive indentation or bad line breaks.
>
> deep_profiler/Mmakefile:
> 	Handle the new mdprof_dump program.
>

That looks fine.

Julien.


--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list