[m-rev.] for review: do not allow non-abstract instance decls in interfaces

Julien Fischer juliensf at cs.mu.OZ.AU
Mon Apr 11 16:57:28 AEST 2005


On Mon, 11 Apr 2005, Ian MacLarty wrote:

> On 11 Apr 2005, at 13:51, Julien Fischer wrote:
>
> >
> > For review by anyone.
> >
> > Estimated hours taken: 2
> > Branches: main, release
> >
> > Fix a long standing problem where the compiler would accept
> > non-abstract instance declarations in module interfaces, despite
> > the reference manual disallowing these.
> >
> > compiler/modules.m:
> > 	Emit an error message when a non-abstract instance
> > 	declaration occurs in a module interface.
> >
> > tests/invalid/Mmakefile:
> > tests/invalid/instance_bug.m:
> > tests/invalid/instance_bug.err_exp:
> > 	Test case for the above.
> >
> > Julien.
> >
>
> This all looks fine to me.
>

By itself yes; unfortunately there were about 37 test cases that had
non-abstract instances in their interfaces and parts of the reference
manual are a bit misleading as well.  I'll post a revised diff of this
either tonight or tomorrow.

Cheers,
Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list