[m-rev.] For review: Made declarative debugger use mdb format settings

[Ian MacLarty]

On Fri, Oct 22, 2004 at 06:34:43PM +1000, Julien Fischer wrote:
> 
> On Thu, 21 Oct 2004, Ian MacLarty wrote:
> 
> > Made the declarative debugger respect the format settings of the procedural
> > debugger.  So the print format set in the procedural debugger will be used when
> > the declarative debugger asks questions and the browse format will be used when
> > browsing terms in the declarative debugger.  If the user changes the browser
> > format during a declarative debugging session the procedural debugger will
> > respect these changes.
> >
> I'd suggest rewording the first part of that as follows:
> 
> Make the declarative debugger respect the format settings of the
> procedural debugger.  The print format set in procedural debugger will
> now be used when the declarative debugger asks questions and the browse
> format will now be used when browsing terms in the declarative debugger.
> 
Why use "Make" instead of "Made"?  I'm describing the changes I *made* to the
declarative debugger.  Or should I write the log in the context of "these are
the changes I will be *making* to the debugger when I commit this"?  The past
tense seems to make more sense when reading the log messages post-commit.

> > trace/mercury_trace_browse.c
> > trace/mercury_trace_browse.h
> > 	Exported global which stores the state of the procedural debugger
> > 	term browser and the function which initialises this state, so they can
> > 	be used from mercury_trace_declarative.c.
> 
> s/global/a global variable/
> 
Changed to : "Exported the global variable which ...".  Using "a" makes it 
sound as if I'm introducing a new variable.

Should I be changing "Exported" to "Export"?

> > +void	MR_trace_browse_ensure_init(void);
> >
> 
> The function prototype for MR_trace_browse_ensure_init() is now in
> the header file; there's no point having another one here.
> 
Removed the prototype from the .c file.

> > --- trace/mercury_trace_browse.h	13 May 2004 08:50:32 -0000	1.16
> > +++ trace/mercury_trace_browse.h	21 Oct 2004 03:58:29 -0000
> > @@ -106,4 +106,8 @@
> >  			int num_imports, MR_Word imports_list);
> >  #endif
> >
> > +extern	MR_Word	MR_trace_browser_persistent_state;
> > +
> > +extern	void	MR_trace_browse_ensure_init(void);
> > +
> >  #endif	/* MERCURY_TRACE_BROWSE_H */
> 
> It wouldn't hurt to have a brief comment here describing what
> these do.
> 
+/* 
+** Points to the state of the interactive term browser that should persist
+** between browsing sessions, like the format settings.
+*/
+extern	MR_Word	MR_trace_browser_persistent_state;
+
+/*
+** Initializes the interactive term browser persistent state or does nothing
+** if it's already been initialized.
+*/
+extern	void	MR_trace_browse_ensure_init(void);
+

Thanks for the comments.
Ian.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------