[m-rev.] for post-commit review: fix deep profiling (part 1 of 2)

Fergus Henderson fjh at cs.mu.OZ.AU
Mon May 31 08:16:09 AEST 2004


That looks good!

Just one very minor comment:

On 19-May-2004, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> Index: library/exception.m
...
> @@ -1433,23 +1437,35 @@
>  **	print a warning and then continue.  It might be better to just
>  **	`#ifdef' out all this code (and the code in builtin_throw which
>  **	calls it) if MR_STACK_TRACE is not defined.
> +**
> +**	(2) In deep profiling grades, execute the actions appropriate for
> +**	    execution leaving the procedure invocation via the exception port.
> +**	    (Deep profiling grades always set MR_STACK_TRACE, so in such grades
> +**	    we *will* be able to traverse the stack all the way.

Missing close parenthesis in the comment.

-- 
Fergus Henderson                    |  "I have always known that the pursuit
                                    |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list