[m-rev.] for review: enable default use of MS Visual C runtime

Fergus Henderson fjh at cs.mu.OZ.AU
Sun Mar 28 05:10:05 AEST 2004


On 23-Mar-2004, Peter Ross <pro at missioncriticalit.com> wrote:
> +AC_ARG_ENABLE(msvcrt,
> +[  --enable-msvcrt
> +                          use the MS Visual C runtime if using MS C compiler.],
> +ac_msvcrt=yes,ac_msvcrt=no)

This variable name is in the ac_* namespace, which is reserved for
autoconf.  You should use a mercury_cv_ prefix instead.

> Index: scripts/ml.in
...
> +# Set the correct flags if we're to use the MS Visual C runtime.
> +use_msvcrt=@USE_MSVCRT@
> +if test $use_msvcrt = "yes"; then
> +	MSVCRT_OPTS="/MD"

Please add a comment here explaining the meaning of the "/MD" option
and why it is needed.

-- 
Fergus Henderson                    |  "I have always known that the pursuit
                                    |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list