[m-rev.] for review: add is_list/4 and list_base/3 to opengl binding

Fergus Henderson fjh at cs.mu.OZ.AU
Wed Jan 14 17:27:25 AEDT 2004


On 14-Jan-2004, Julien Fischer <juliensf at students.cs.mu.OZ.AU> wrote:
> 
> extras/graphics/mercury_opengl/mogl.m:
> 	Add bindings for glIsList() and glListBase().
>... 
> +:- pragma foreign_proc("C",
> +	is_list(L::in, R::out, IO0::di, IO::uo),
> +	[may_call_mercury, promise_pure],
> +"
> +	if(glIsList((GLuint) L))
> +		R = ML_bool_return_yes();
> +	else
> +		R = ML_bool_return_no();

s/if(/if (/

Add curly braces (see our C coding guidelines).

Otherwise, that looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list