[m-rev.] for review: curs binding updates

Julien Fischer juliensf at cs.mu.OZ.AU
Thu Dec 2 13:57:05 AEDT 2004


On Thu, 2 Dec 2004, Peter Wang wrote:

> On Wednesday 01 December 2004 04:04 pm, Julien Fischer wrote:
> >
> > That looks fine otherwise.
> > Can you post a relative diff when you've made the changes I suggest above.
>
> Here it is:
>
> --- curs.m.1	2004-12-01 16:22:30.000000000 +1100
> +++ curs.m	2004-12-01 16:28:38.000000000 +1100
> @@ -39,7 +39,7 @@
>  :- pred start(io__state::di, io__state::uo) is det.
>
>      % Enable or disable the no-delay option.  If enabled (first argument is
> -    % true) then getch will be a non-blocking call, i.e. return immediately
> +    % yes) then getch will be a non-blocking call, i.e. return immediately
>      % if no input is ready rather than waiting for input.
>      %
>  :- pred nodelay(bool::in, io__state::di, io__state::uo) is det.
> @@ -89,6 +89,12 @@
>      %
>  :- pred refresh(io__state::di, io__state::uo) is det.
>
> +    % This was supposed to do what refresh does but without preceding calls
> +    % to wnoutrefresh it does nothing.
> +    %
> +:- pragma obsolete(doupdate/2).
> +:- pred doupdate(io__state::di, io__state::uo) is det.
> +
>      % Read a character from the keyboard (unbuffered) and translate it
>      % if necessary.  In no-delay mode, if no input is waiting, the value
>      % curs__err is returned.
> @@ -576,6 +582,16 @@
>
>  %
> ----------------------------------------------------------------------------
> %
>
> +:- pragma foreign_proc("C", doupdate(IO0::di, IO::uo),
> +    [will_not_call_mercury, promise_pure], "
> +
> +    doupdate();
> +    IO = IO0;
> +
> +").
> +
> +%
> ----------------------------------------------------------------------------
> %
> +
>  :- pragma foreign_proc("C", getch(CharCode::out, IO0::di, IO::uo),
>      [will_not_call_mercury, promise_pure], "
>
That looks fine, you can commit that.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list