[m-rev.] diff: mtags: use perl -w

Peter Moulder Peter.Moulder at infotech.monash.edu.au
Mon Nov 24 16:26:54 AEDT 2003

On Mon, Nov 24, 2003 at 02:59:01PM +1100, Fergus Henderson wrote:

> 	- use "&foo" instead of the deprecated "do foo" notation for
> 	  calling subroutines

Using &foo() rather than foo() disables prototype checking.  You
probably don't want that.  If perl gives unsightly warnings about not
checking prototypes because of call-before-declaration, you can add
forward declarations (a la C):

  sub output_name();
  sub output_single_name();
  sub output_single_tag();

(Heathens may instead suggest defining the subroutine before calling

No other issues with this diff that I could see.

mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe

More information about the reviews mailing list