[m-rev.] for review: make array a foreign type

Fergus Henderson fjh at cs.mu.OZ.AU
Fri May 16 23:04:39 AEST 2003


On 16-May-2003, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> For review by Fergus: does the IL foreign_type definition look right?

Yes, it does.

> This change bootchecked in asm_fast.gc with and without debugging.
> It failed in hlc.gc, but I fixed the reason for that in another diff
> (the one to mlds.m).

This diff looks fine, but the change to mlds.m which it depends on doesn't.
That change to mlds.m will break the way we handle arrays for the
Java and IL back-ends.

> Other diffs to make other currently builtin types into foreign types will
> come shortly. I had enough trouble with this one :-)

That's fine.  In fact I prefer it this way -- it's actually a lot easier
to review when broken into bite-size chunks like this.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list