[m-rev.] for review: fix equivalence type performance problems

[Fergus Henderson]

On 18-Dec-2003, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> On 18-Dec-2003, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > On 18-Dec-2003, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> > > On 18-Dec-2003, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > > > On 17-Dec-2003, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> > > > > On 12-Dec-2003, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > > > > > On 12-Dec-2003, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> > > > > > > compiler/mercury_compile.m:
> > > > > > > 	Re-enable equiv_type_hlds.m.
> > > > > > > 
> > > > > > > tests/hard_coded/Mmakefile:
> > > > > > > 	Re-enable testing of equiv_type_hlds.m.
> > > > > > 
> > > > > > I would like to see some performance figures for how much
> > > > > > it costs to run this extra pass before we re-enable it.
> > > > > 
> > > > > With the extra change below, the equiv_type_hlds pass adds about
> > > > > 5% to compile time, much of that in equiv_type.replace_in_type.
> > > > 
> > > > The extra changes below are fine.
> > > > 
> > > > I'd still rather avoid the extra 5% if we can...
> > > > for the --high-level-data grades we can't, but is this pass
> > > > really needed for the hlc and LLDS grades?
> > > 
> > > I'd say yes, because otherwise `:- pragma foreign_proc' and
> > > `:- pragma export' will behave differently in different grades;
> > > the foreign types of the arguments will be different.
> > 
> > Could we just expand equivalence types when converting Mercury types
> > to foreign types?  In particular, in foreign__to_exported_type?
> 
> You wrote earlier:
> > It's also needed by the MLDS->C back-end, for either --high-level-data,
> > or for cases involving abstract equivalence types which are defined
> > as "float".
> 
> So it is needed for hlc grades.

All right, I give in :-)

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------