[m-rev.] for review: Changes to time library test cases

James Goddard goddardjames at yahoo.com
Wed Dec 17 15:07:15 AEDT 2003


> This fragment of the diff, which enables all of the tests in this
> directory in grade "java", was not mentioned in the log message,

> This fragment should not be committed, unless all of those tests
> actually pass in grade "java" (which I doubt).  Instead, only
> those tests which actually pass should be enabled.  Hopefully
> that should include time_test and dst_test.

Is this the sort of thing you had in mind?

diff -u Mmakefile Mmakefile
--- Mmakefile	17 Dec 2003 01:14:20 -0000
+++ Mmakefile	17 Dec 2003 03:53:49 -0000
@@ -177,6 +177,49 @@
 	write_reg1 \
 	write_reg2
 
+# JAVA_PASS_PROGS lists those tests which will succeed in grade Java.
+
+JAVA_PASS_PROGS= \
+	address_of_builtins \
+	brace \
+	c_write_string \
+	compare_spec \
+	contains_char \
+	constraint \
+	curry \
+	cut_test \
+	deforest_cc_bug \
+	division_test \
+	dot_separator \
+	dst_test \
+	existential_type_switch_opt \
+	failure_unify \
+	foreign_and_mercury \
+	foreign_type \
+	free_free_mode \
+	func_and_pred \
+	func_test \
+	higher_order_func_test \
+	higher_order_syntax \
+	ho_func_reg \
+	join_list \
+	mapped_module \
+	no_inline_builtins \
+	no_warn_singleton \
+	nondet_ctrl_vn \
+	nondet_copy_out \
+	pragma_inline \
+	qual_basic_test \
+	reorder_di \
+	rev_arith \
+	reverse_arith \
+	solve_quadratic \
+	string_alignment \
+	string_loop \
+	string_suffix_bug \
+	target_mlobjs \
+	time_test 
+
 # Tests of the C#, MC++, and IL foreign language interfaces only
 # work in IL grades
 ifeq "$(filter il%,$(GRADE))" ""
@@ -346,18 +389,17 @@
 	endif
 endif
 
-# We currently don't do any testing in grade java on this directory,
-# except for java_test.m.
-#ifneq "$(findstring java,$(GRADE))" ""
-#	PROGS = $(JAVA_PROGS)
-#else
+# We currently test only a limited selection in grade java on this directory.
+ifneq "$(findstring java,$(GRADE))" ""
+	PROGS = $(JAVA_PROGS) $(JAVA_PASS_PROGS)
+else
 	PROGS = $(ORDINARY_PROGS) $(BROKEN_FOR_LCC_PROGS) \
 		$(CLOSURE_LAYOUT_PROGS) $(EXCEPTION_PROGS) \
 		$(BACKEND_PROGS) $(NONDET_C_PROGS) \
 		$(C_AND_GC_ONLY_PROGS) $(STATIC_LINK_PROGS) \
 		$(CHAR_REP_PROGS) $(BROKEN_FOR_PROFDEEP)  \
 		$(FACTT_PROGS) $(DOTNET_PROGS) $(JAVA_PROGS)
-#endif
+endif
 
 # --split-c-files does not work in the hl* grades (e.g. hlc.gc),
 # because it hasn't yet been implemented yet.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list