[m-rev.] for review: Java implementation of time library now tested and correct

[James Goddard]

> So yes, please keep the milliseconds, and change the
> test case.
> 

Will do.

> What happened to the code using DST_OFFSET?
> 

It turns out that the DST_OFFSET value changes
depending on whether the current time the Calendar is
set to is daylight savings or not.

For Melbourne, get(DST_OFFSET) returns 3600000 during
daylight savings and 0 at other times.

So, if the value was supposed to be DST but isn't,
then subtracting get(DST_OFFSET) will have no effect
whatsoever.  That's why I hard-coded 3600000
milliseconds.

Having said that, I didn't realize different timezones
had different DST offsets.  I'll change it to use
SimpleTimeZone.getDSTSavings(), which stays constant.

http://personals.yahoo.com.au - Yahoo! Personals
New people, new possibilities. FREE for a limited time.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------