[m-rev.] for review: fix yet another termination analysis bug

Fergus Henderson fjh at cs.mu.OZ.AU
Mon Dec 15 14:51:39 AEDT 2003


On 15-Dec-2003, Julien Fischer <juliensf at students.cs.mu.OZ.AU> wrote:
> 
> Fix a bug in the termination analysis that causes a software error
> during pass 2.  This is due to a sanity check failing.
...
> +++ compiler/term_pass2.m	15 Dec 2003 03:19:34 -0000
> @@ -65,6 +65,9 @@
> 
>  %-----------------------------------------------------------------------------
> 
> +	% NOTE: This code assumes that the SCC does not call any
> +	% nonterminating procedures.  If it does then that fact
> +	% should have been detected during pass 1.
>  prove_termination_in_scc(SCC, Module, PassInfo, SingleArgs, Termination) :-

That comment should probably go in the module interface, with the pred
declaration, rather than in the implementation.

Otherwise this diff looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list