[m-rev.] for review: SHARED_LIBS

[Fergus Henderson]

On 13-Sep-2002, Fergus Henderson <fjh at cs.mu.oz.au> wrote:
> On 12-Sep-2002, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> > configure.in:
> > 	Fix a bug: the variable SHARED_LIBS is destined to be put on the right
> > 	hand side of a make variable definition, so wrap the make variable names
> > 	inside it in ().
> 
> That looks fine.

Actually, no on second thoughts it doesn't look fine.
What you have would be OK *if* "CC" was defined as a variable by Mmake,
but currently it is not.

Probably a better fix is to expand $CC when executing the configure
script, rather than leaving the reference to be expaneded by Mmake.
The code fragment in question only works if $CC is (some version of) GCC,
so delaying the expansion of $CC to Mmake-time would increase
the opportunities for the user to shoot themself in the foot.
I will post a diff shortly.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------