[m-rev.] for review: installing the default grade

Fergus Henderson fjh at cs.mu.OZ.AU
Tue Oct 15 16:21:00 AEST 2002


On 15-Oct-2002, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> On 14-Oct-2002, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > Estimated hours taken: 0.75
> > Branches: main
> > 
> > Change things so that LIBGRADES includes the default grade.
> > This fixes a bug that sometimes caused the libraries not to be
> > installed in the default grade, e.g. when $(GRADE) is set in Mmake.params.
>  
> > Mmakefile:
> > scripts/Mmake.rules:
> > 	Change the loops over $(ALL_LIBGRADES) so that they skip $(GRADE).
> 
> You'll also need to do this in the library installation code in
> compiler/make.program_target.m.

Done.

cvs diff: Diffing .
Index: make.program_target.m
===================================================================
RCS file: /home/mercury1/repository/mercury/compiler/make.program_target.m,v
retrieving revision 1.11
diff -u -d -u -r1.11 make.program_target.m
--- make.program_target.m	26 Aug 2002 04:56:58 -0000	1.11
+++ make.program_target.m	15 Oct 2002 06:19:17 -0000
@@ -480,8 +480,9 @@
 		{ GradeSucceeded = yes }
 	->
 		% XXX With Mmake, LIBGRADES is target-specific.
-        	globals__io_lookup_accumulating_option(libgrades, LibGrades),
+        	globals__io_lookup_accumulating_option(libgrades, LibGrades0),
 		globals__io_lookup_bool_option(keep_going, KeepGoing),
+		{ LibGrades = list__delete_all(LibGrades0, Grade) },
         	foldl2_maybe_stop_at_error(KeepGoing,
 			install_library_grade(LinkSucceeded,
 				MainModuleName, AllModules),
-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list