[m-rev.] diff: more string_format test fine-tuning

[Fergus Henderson]

On 23-Nov-2002, Peter Ross <pro at missioncriticalit.com> wrote:
> More fixes for the string_format tests.
> 
> tests/general/string_format/Mmakefile:
>     Disable string_format_o on Solaris 5.1 instead of taifun.
>     Disable floating point tests on DEC OSF1 due to problems with
>     denormal numbers.

I would prefer a more fine-grained approach which just disabled the
tests of denormal numbers.  DEC OSF1 is one of the few systems on which
floating point division by zero will raise an exception by default,
so IMHO it is important to test floating point on that system.

> +	# On solaris 5.7 string_format_o fails because of a buggy
> +	# sprintf implementation.
> +SOLARIS_FAILURES=string_format_o

It also fails on Solaris 5.8.

> +UNAME=$(shell uname -r -s)
> +ifneq "$(findstring SunOS 5.7,$(UNAME))" ""
> +	PROGS=$(filter-out $(SOLARIS_FAILURES),$(PROGS0))
>  else
> +  ifneq "$(findstring OSF1 V5.1,$(UNAME))" ""
> +	PROGS=$(filter-out $(OSF1_FAILURES),$(PROGS0))
> +  else
>  	PROGS=$(PROGS0)
> +  endif
>  endif

It would be more effiicient to use

	UNAME := $(shell uname -r -s)

so that the `uname' process is only invoked once.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------