[m-rev.] for review: fix mundroo readline linking problem

Fergus Henderson fjh at cs.mu.OZ.AU
Tue Nov 19 14:48:56 AEDT 2002


On 19-Nov-2002, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> 
> Estimated hours taken: 1
> Branches: main, release
> 
> scripts/ml.in:
> 	Search /usr/local/lib for shared libraries. This fixes
> 	problems linking debugging executables on mundroo.
...
> +case $all_libs in
> +	shared) system_shlib_dirs="/usr/local/lib" ;;
> +	static)	system_shlib_dirs="" ;;
> +esac

What happens if there is no /usr/local/lib directory?
Do you get a warning or error in that case?

I think it might be safest to only include /usr/local/lib if
"[ -d /usr/local/lib/. ]" succeeds.  (The "/." is to account for
the case where /usr/local/lib is a symlink.)

Otherwise that looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list