[m-rev.] diff: conditionalie references to EINTR

Fergus Henderson fjh at cs.mu.OZ.AU
Sun Nov 10 00:27:21 AEDT 2002


On 10-Nov-2002, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> 
> Only refer to EINTR if it is defined.
> 
> runtime/mercury_std.h:
> 	Add a macro MR_is_eintr which tests whether its
> 	argument is EINTR, or returns false if EINTR
> 	not undefined.
> 
> trace/mercury_trace_internal.c:
> compiler/process_util.m:
> 	Use MR_is_eintr.

That looks good, thanks.

BTW it looks like your patch also included a bug fix which was
not mentioned in the log message:

> Index: trace/mercury_trace_internal.c
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/trace/mercury_trace_internal.c,v
> retrieving revision 1.148
> diff -u -u -r1.148 mercury_trace_internal.c
> --- trace/mercury_trace_internal.c	8 Nov 2002 08:48:23 -0000	1.148
> +++ trace/mercury_trace_internal.c	9 Nov 2002 12:32:58 -0000
> @@ -882,15 +882,20 @@
>  		MR_setup_signal_no_restart(SIGALRM,
>  			MR_trace_internal_alarm_handler, MR_FALSE,
>  			"error setting up alarm handler");
> +		MR_got_alarm = MR_FALSE;
>  		alarm(10);	/* 10 second timeout */

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list