[m-rev.] diff: fixes for trailed_update tests

Fergus Henderson fjh at cs.mu.OZ.AU
Thu Nov 7 17:05:42 AEDT 2002


On 05-Nov-2002, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> Fix some problems with the trailed_update tests.
> 
> extras/trailed_update/var.m:
> 	Document that this module doesn't work in `.rt' grades (and why).
> 
> extras/trailed_update/samples/Mmakefile:
> 	Disable the vqueens test in `.rt' grades.
> 	Also, enable the interpreter test, since the reason for disabling
> 	it is no longer valid now that the value numbering pass has been
> 	deleted.
> 	Also, use $(DIFF_OPTS) rather than hard-coding "-c".
> 
> extras/trailed_update/samples/interpreter.exp:
> 	Update to reflect the current output,
> 	which has different variable numbers than the original output.
> 	(The output also changed slightly when interpreter.m was changed
> 	to use store__new rather than store__init.)

It turned out that the "interpreter" test was failing in `.rt' grades too,
although for a different reason -- it is due to a bug with unification of
values of type "store__mutvar" in ".rt" grades.

--- CHANGES.old	Thu Nov  7 17:01:09 2002
+++ CHANGES	Thu Nov  7 17:03:26 2002
@@ -1,6 +1,6 @@
 
 Branches: main
-Estimated hours taken: 3
+Estimated hours taken: 4
 
 Fix some problems with the trailed_update tests.
 
@@ -11,7 +11,8 @@
 	Disable the vqueens test in `.rt' grades.
 	Also, enable the interpreter test, since the reason for disabling
 	it is no longer valid now that the value numbering pass has been
-	deleted.
+	deleted.  But disable it for `.rt' grades, since it turns out
+	to fail for those.
 	Also, use $(DIFF_OPTS) rather than hard-coding "-c".
 
 extras/trailed_update/samples/interpreter.exp:
 extras/trailed_update/samples/interpreter.exp:
diff -u extras/trailed_update/samples/Mmakefile extras/trailed_update/samples/Mmakefile
--- extras/trailed_update/samples/Mmakefile	5 Nov 2002 06:34:04 -0000
+++ extras/trailed_update/samples/Mmakefile	5 Nov 2002 08:26:04 -0000
@@ -33,8 +33,11 @@
 
 # The "vqueens" program does not work in ".rt" grades,
 # since it uses the "var" module which does not work in ".rt" grades.
+# The "interpreter" program does not work in ".rt" grades either,
+# due to a bug with unification of values of type "store__mutvar" in ".rt"
+# grades.
 ifeq "$(findstring .rt,$(GRADE))" ".rt"
-PROGS	=	interpreter
+PROGS	=	
 else
 PROGS	=	interpreter vqueens
 endif

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list