[m-rev.] for review: controlling retry across I/O

Mark Brown dougl at cs.mu.OZ.AU
Fri Nov 1 16:42:55 AEDT 2002


On 30-Oct-2002, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> trace/mercury_trace_internal.c:
> 	Make indirect retries (used only in minimal model grades) use only safe
> 	retries.

What is the rationale for this part of the change?  What if the original
retry command specified -i or -f?

> Index: doc/user_guide.texi
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/doc/user_guide.texi,v
> retrieving revision 1.333
> diff -u -b -r1.333 user_guide.texi
> --- doc/user_guide.texi	26 Oct 2002 14:15:33 -0000	1.333
> +++ doc/user_guide.texi	30 Oct 2002 03:47:22 -0000
> @@ -2331,13 +2331,19 @@
>  
>  @sp 1
>  @table @code
> - at item retry [-f]
> + at item retry [-fio] [@var{num}]

You should document the -a option too, but leave it commented out.

> @@ -2382,26 +2395,6 @@
>  @c This may require a noticeable amount of time.
>  @c XXX not yet
>  @c and may result in the execution of I/O and/or other side-effects.

The comment above needs to be updated.

> + at item dd_dd
> + at c @item dd_dd [filename]
> + at c XXX Mark, please document the optional argument of dd_dd

No problem.

Cheers,
Mark.

--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list