[m-rev.] for review: stack slot optimization, part 5

Ralph Becket rafe at cs.mu.OZ.AU
Thu Mar 14 10:41:16 AEDT 2002


Fergus Henderson, Wednesday, 13 March 2002:
> On 09-Mar-2002, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> 
> > +record_interval_vars(Id, NewVars, OptInfo0, OptInfo) :-
> > +	VarsMap0 = OptInfo0 ^ interval_vars,
> > +	% XXX should be map__lookup
> > +	( map__search(VarsMap0, Id, Vars0) ->
> > +		Vars = set__insert_list(Vars0, NewVars),
> > +		map__det_update(VarsMap0, Id, Vars, VarsMap)
> > +	;
> > +		set__list_to_set(NewVars, Vars),
> > +		map__det_insert(VarsMap0, Id, Vars, VarsMap)
> > +	),
> 
> Why isn't it map__lookup?

Or preferably `VarsMap0 ^ [det_]elem(Id) = Vars0'.

- Ralph
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list