[m-rev.] for review: Add java support for the function foreign__to_type_string/2

[Andre Yang]

On Tue, Mar 12, 2002 at 06:35:36AM +1100, Fergus Henderson wrote:
> 
> That looks like it is not correct.
> 
> 1.  For consistency with mlds_to_java.m, all Java names that we generate
> should be fully-qualified, so it should be "java.lang.String"
> and "java.lang.Object" rather than "String" and "Object".
> 
ok
> 2.  I think special handling may be needed here for other types,
> similar to that in mercury_output_type in mlds_to_java.m.
> 
Hi
I took a look at the mlds_to_java__output_type, there seems to be also no full qualified names. should there also be changed? for other types I think it will make sense to add the boolean type, but 
1.should not for all foreign languages have  the same supported types by the passed parameters?.
2. why is boolean not passed by the standard?
>In fact, to verify the correctness, I'd like to see the documentation,
> but there's no documentation.  At very least you should add an XXX
> comment saying that this code might not be correct.
> 
sorry, I didn't think too much at this point , saw the c construct several lines above, and thought It will be cause no problem  here. 
   
> Even better would be to add the appropriate "Language-specific binding"
> section for Java in the Mercury language reference manual; then we could
> verify whether this code does what the reference manual says it should do.
> 
I'm planing to do the documentation all together with the next packet(the implementation for foreign_decl foreign_code and foreign_proc), because this part is only used by me.

regards


-- 
Andre Yang 
ayang at rationalizer.com
The Rationalizer Intelligent Software AG
Rudower Chaussee 29, 12489 Berlin, Germany
Tel: +49 30 678060-16 
Fax: +49 30 678060-29

This e-mail contains confidential information which is the property 
of THE RATIONALIZER. If you are not the proper recipient of the message, 
or if you have doubts about being the proper recipient, please delete 
the message immediately. In this case, we would be delighted if you 
could inform us under mail at rationalizer.com.

--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------