[m-rev.] for review: MLDS back-end: generate closure layouts

Fergus Henderson fjh at cs.mu.OZ.AU
Sun Mar 3 21:49:52 AEDT 2002


Here's the relative diff in response to petdr's review comments.
I will go ahead and commit this now.

--- CHANGES10.old	Sun Mar  3 21:42:35 2002
+++ CHANGES10	Sun Mar  3 21:44:21 2002
@@ -32,7 +32,10 @@
 	it just checks for `data(_)' rather than `data(var(_))'.
 
 compiler/rtti_to_mlds.m:
-	Mark RTTI definitions as `final', and document why.
+	Mark RTTI definitions as `final'; this is needed to ensure
+	that they have the same flags (apart from the access) as
+	ml_static_const_flags, so that ml_decl_is_static_const succeeeds
+	for these.
 
 compiler/ml_optimize.m:
 	Update to reflect the interface changes in ml_util.m.

--- stack_layout.m.old	Sun Mar  3 21:48:31 2002
+++ stack_layout.m	Sun Mar  3 21:47:35 2002
@@ -42,6 +42,8 @@
 	create_arg_types::out, comp_gen_c_data::out,
 	counter::in, counter::out) is det.
 
+	% Construct a representation of a variable location as a 32-bit
+	% integer.
 :- pred stack_layout__represent_locn_as_int(layout_locn::in, int::out) is det.
 
 :- implementation.
-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list