[m-rev.] for review: naming magling, step 1

Simon Taylor stayl at cs.mu.OZ.AU
Thu Feb 7 23:58:09 AEDT 2002


On 07-Jan-2002, Mark Brown <dougl at cs.mu.OZ.AU> wrote:
> On 04-Jan-2002, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> > The first step towards centralizing name construction and mangling issues
> > in the browser directory.

> > browser/names.m:
> > 	A new module for holding information about the structure of names.
> > 
> > browser/mangle.m:
> > 	A new module for handling name mangling, i.e. the conversion of names
> > 	to and from a form acceptable inside C identifiers.
> > 
> > 	It implements a new scheme for name manging, which (unlike the previous
> > 	scheme) does not obscure a whole name just because one part contains
> > 	characters that cannot occur in identifiers.
> > 
> > browser/dl.m:
> > browser/name_mangle.m:
> > 	Make these modules stand on their own, not as submodules of module mdb.
> > 	They are needed in other places as well.
> 
> The reason we introduced the super-module mdb was to minimise a problem
> with browser modules polluting the user's namespace.  Making these
> modules standalone will cause that problem to re-occur, unless there is
> something I missed.  Moving the modules out of mdb is fine, but you
> should put them all in another super-module (e.g. mercury_util).
> 
> See http://www.cs.mu.oz.au/research/mercury/mailing-lists/mercury-developers/mercury-developers.0002/0026.html
> for the original change.
> 
> (Note that I haven't reviewed this change.)

I've reviewed the change, and this was the only problem I could see.

Simon.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list