[m-rev.] mercury_grade.h (attempt 3)

Fergus Henderson fjh at cs.mu.OZ.AU
Sat Dec 21 16:46:08 AEDT 2002


On 20-Dec-2002, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> For both branches; for review by Fergus.
> 
> runtime/mercury_grade.h:
> 	Fix a bug: the value of MR_DEEP_PROFILING wasn't being taken into
> 	account in computing MR_GRADE_OPT.
> 
> 	Fix the double maintenance problem that led to the bug: instead of
> 	comnputing MR_GRADE and MR_GRADE_OPT in separate chains of #ifdefs,
> 	compute them in the same chain.

This looks fine for the main branch,
but I don't think the bug that it fixes is important enough to warrant
committing it on the release branch at this point.  MR_GRADE_OPT
is only used for interactive queries in the debugger (and `collect'
in the external debugger).  I don't think anyone except Mercury
developers is going to be using both debugging and deep profiling
at the same time, let alone debugging and deep profiling and interactive
queries, and Mercury developers who use it would use the main branch anyway.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list