[m-rev.] for review: mmc --make for external foreign files improvements

Fergus Henderson fjh at cs.mu.OZ.AU
Thu Dec 19 02:22:20 AEDT 2002


On 18-Dec-2002, Peter Ross <pro at missioncriticalit.com> wrote:
> compiler/handle_options.m:
> 	Fix a bug where copmute_grade incorrectly generated `hl.il'
> 	instead of `il' as the grade name because we weren't always
> 	considering the --target option.

Another possible fix for this would be to change this module so that
where the comment says

>  			% For possible component of the grade string
>  			% include it in the actual grade string if all
>  			% the option setting that it implies are true.

it should instead say

>  			% For each possible component of the grade string
>  			% include it in the actual grade string if all
>  			% the option setting that it implies are true,
			% AND there is no other grade component whose
			% settings are all true which includes all of
			% the settings of this grade component.

and to update the code accordingly.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list