[m-rev.] diff: fix tests/hard_coded/parse failure

Simon Taylor stayl at cs.mu.OZ.AU
Sun Dec 1 14:38:10 AEDT 2002


On 01-Dec-2002, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > --- Mmakefile	24 Nov 2002 04:32:12 -0000	1.173.2.4
> > +++ Mmakefile	29 Nov 2002 10:05:16 -0000
> > @@ -274,10 +274,13 @@
> >  
> >  # Static linking doesn't work on Solaris in debug grades
> >  # ('-ldl' doesn't work with static linking).
> > +STATIC_LINK_PROGS =
> >  ifneq "$(findstring solaris,$(FULLARCH)) $(findstring debug,$(GRADE))" "solaris debug"
> > -	STATIC_LINK_PROGS = parse
> > -else
> > -	STATIC_LINK_PROGS =
> > +	# The `parse' test also links with the debug libraries,
> > +	# so it only works in LLDS grades.
> > +	ifeq "$(filter hl% java% il%,$(GRADE))" ""
> > +		STATIC_LINK_PROGS = parse
> > +	endif
> >  endif
> 
> I think this will result in Mmake warnings about $(STATIC_LINK_PROGS)
> not being defined.

I think you missed the first '+' line.

Simon.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list