[m-rev.] for review: deep profiling fixes, determinism algorithm change

[Fergus Henderson]

On 13-Aug-2002, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> Index: runtime/mercury_debug.c
...
> +	if (MR_lld_print_enabled == 0) {
> +		return;
> +	}

If MR_lld_print_enabled is a boolean, then it would be nicer to write
that as

	if (!MR_lld_print_enabled) {
		return;
	}

> +++ tools/lmc	2002/08/10 13:57:54
>  
> +if test "$MMC_LOWLEVEL_DEBUG" != ""
> +then
> +	CDEBUG_FLAGS="$CDEBUG_FLAGS --cflags -DMR_LOWLEVEL_DEBUG"
> +else
> +	CDEBUG_FLAGS=""
> +fi
> +
> +if test "$ADDED_CFLAGS" != ""
> +then
> +	CDEBUG_FLAGS="$CDEBUG_FLAGS --cflags \"$ADDED_CFLAGS\""
> +fi

MMC_LOWLEVEL_DEBUG and ADDED_CFLAGS should be documented
in the comments at the top of this file.

Also it might be better to use the MMC_ prefix for ADDED_CFLAGS too.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------