[m-rev.] Updated diff for deep profiling.

Fergus Henderson fjh at cs.mu.OZ.AU
Tue May 29 01:12:06 AEST 2001


On 28-May-2001, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> Here is the entire updated diff. I tried to use interdiff to show just what I
> have done since the previous full diff, but this yielded nonsensical results
> that I can't debug without the nonexistent interdiff manual.

If interdiff doesn't work, you can produce a relative diff by checking
out two fresh copies of the repository (using a tag or date which
matches the workspace that you used to produce the diffs, to avoid any
new conflicts), applying the old and new diffs that you posted, and
then using `diff --recursive'.

In this particular case you should probably also do `mv deep deep_profiler'
to avoid spurious differences resulting from that directory renaming.

I think it is important to always produce relative diffs for any
substantial changes.  IMHO code should not be committed into the
repository unless the other members of the group are given the
opportunity to review it.  And reposting a 25000 line diff in which
some new changes are scattered (like needles in a haystack ;-) does not
really give any effective opportunity for review.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
                                    |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list