[m-rev.] for review: self rval

Tyson Dowd trd at cs.mu.OZ.AU
Thu Jun 21 02:04:58 AEST 2001


On 21-Jun-2001, Peter Ross <petdr at cs.mu.OZ.AU> wrote:
> Hi,
> 
> For Tyson to review.  Could you answer the XXX in the code for
> rval_to_type please.


self should probably be self(mlds__type) so that we can find out what
the type of self is.

This is similar to how we put the mlds__type into the var lval.

> Index: compiler/mlds_to_mcpp.m
> ===================================================================
> RCS file: /home/staff/zs/imp/mercury/compiler/mlds_to_mcpp.m,v
> retrieving revision 1.6
> diff -u -r1.6 mlds_to_mcpp.m
> --- compiler/mlds_to_mcpp.m	2001/06/08 09:13:45	1.6
> +++ compiler/mlds_to_mcpp.m	2001/06/20 14:33:04
> @@ -427,6 +427,9 @@
>  
>  write_managed_cpp_rval(mem_addr(_)) -->
>  	io__write_string(" /* mem_addr rval -- unimplemented */ ").
> +
> +write_managed_cpp_rval(self) -->
> +	io__write_string(" /* self rval -- unimplemented */ ").
>  	
>  :- pred write_managed_cpp_rval_const(mlds__rval_const, io__state, io__state).
>  :- mode write_managed_cpp_rval_const(in, di, uo) is det.


Probably best to call unexpected for these (yes, I know this was a
defect in the existing code, but it's pretty easy to fix).
Or you could output "this".

-- 
       Tyson Dowd           # 
                            #  Surreal humour isn't everyone's cup of fur.
     trd at cs.mu.oz.au        # 
http://www.cs.mu.oz.au/~trd #
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list