[m-rev.] for review: line numbers for collect.

Erwan Jahier Erwan.Jahier at irisa.fr
Wed Jul 4 01:17:57 AEST 2001


| On 03-Jul-2001, Erwan Jahier <Erwan.Jahier at irisa.fr> wrote:
...
| What about MR_PORT_EXCEPTION?
| 
| Should you be using MR_port_is_interface() here?
| 
| (I know you only moved that code around in this change...
| I should have pointed that out earlier.)

that's all rigth, thanks. 

Index: 0.3/trace/mercury_trace_external.c
--- 0.3/trace/mercury_trace_external.c Tue, 03 Jul 2001 16:21:24 +0200 jahier (mymercury/x/18_mercury_tr 1.1 640)
+++ 0.3(w)/trace/mercury_trace_external.c Tue, 03 Jul 2001 17:08:24 +0200 jahier (mymercury/x/18_mercury_tr 1.1 640)
@@ -1524,8 +1524,7 @@
 	MR_Word			*base_sp, *base_curfr;
 
 	
-	if ( port == MR_PORT_CALL || port == MR_PORT_EXIT || 
-	     port == MR_PORT_REDO || port == MR_PORT_FAIL ) 
+	if MR_port_is_interface(port)
 	/* 
 	** At external events, we want the line number 
 	** where the call is made, not the one where the 

-- 
R1.


--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list