[m-rev.] for review: fix mode-specific clauses bug

Simon Taylor stayl at cs.mu.OZ.AU
Sat Aug 18 21:33:13 AEST 2001


On 17-Aug-2001, Tyson Dowd <trd at cs.mu.OZ.AU> wrote:
> On 17-Aug-2001, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> > Index: compiler/intermod.m
> > ===================================================================
> > @@ -1437,8 +1437,11 @@
> >  	% where the added arguments for a DCG pred expression
> >  	% are named the same as variables in the enclosing clause.
> >  	{ AppendVarNums = yes },
> > +	{ ForIntermod = yes },
> > +	{ MaybeVarTypes = no },
> >  	hlds_out__write_clause(1, ModuleInfo, PredId, VarSet, AppendVarNums,
> > -		ClauseHeadVars, PredOrFunc, Clause, no).
> > +		ClauseHeadVars, PredOrFunc, Clause, ForIntermod,
> > +		MaybeVarTypes).

> I think the variable name "ForIntermod" is confusing, as
> hlds_out__write_clause refers to this as "UseDeclaredModes".  It's
> conceivable that in future this might cause confusion. 

Fixed.

Simon.

--- intermod.m	2001/08/18 11:00:10	1.2
+++ intermod.m	2001/08/18 11:00:18
@@ -1437,10 +1437,10 @@
 	% where the added arguments for a DCG pred expression
 	% are named the same as variables in the enclosing clause.
 	{ AppendVarNums = yes },
-	{ ForIntermod = yes },
+	{ UseDeclaredModes = yes },
 	{ MaybeVarTypes = no },
 	hlds_out__write_clause(1, ModuleInfo, PredId, VarSet, AppendVarNums,
-		ClauseHeadVars, PredOrFunc, Clause, ForIntermod,
+		ClauseHeadVars, PredOrFunc, Clause, UseDeclaredModes,
 		MaybeVarTypes).
 
 intermod__write_clause(ModuleInfo, PredId, VarSet, _HeadVars,
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list