[m-rev.] Re: for review: --use-local-vars

[Fergus Henderson]

On 23-Apr-2001, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> On 09-Mar-2001, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > Otherwise, that looks fine.
> 
> Here is the interdiff of the changes I made in response to your comments.
> I will commit this tomorrow unless I hear some objection by then.
...
> +++ compiler/options.m
> @@ -2571,0 +2570,3 @@
> +		"--use-local-vars",
> +		"\tDisable the transformation to use local variables in C code",
> +		"\tblocks whereever possible.",

s/Disable/Enable/

> --- doc/user_guide.texi	2001/03/18 23:10:06	1.246
> +++ doc/user_guide.texi	2001/04/20 12:16:19
> @@ -4280,6 +4280,11 @@
...
> + at item --use-local-vars
> +Disable the transformation to use local variables in C code
> +blocks whereever possible.

Likewise.

Also, there was one issue in my original comments that you seem to have
missed: the use of `diff -u'.

In general I think it would be helpful if you could reply to the review
comments, explaining for each one whether you agreed with the comment
and what action was taken.  In the common case, this can be as simple as
"OK".  I don't mind if you don't accept all the comments, but I think
it's worth going through and explicitly replying to each one, otherwise
issues can easily get lost accidentally.

(Don't bother in this particular case, though, since I've already
double-checked it.)

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
                                    |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------