[m-rev.] for review: another MinGW portability fix

Fergus Henderson fjh at cs.mu.OZ.AU
Thu Apr 19 03:53:53 AEST 2001


On 07-Apr-2001, Peter Ross <peter.ross at miscrit.be> wrote:
> On Sat, Apr 07, 2001 at 07:21:00PM +1000, Fergus Henderson wrote:
> > boehm_gc/Makefile:
> > 	If using "if_not_there foo.o $(CC) ..." fails,
> > 	then try "if_not_there foo.o `cygpath -w /bin/sh` -c $(CC) ...".
> > 	This is needed when `if_not_there.c' is compiled with MinGW,
> > 	and $(CC) is a shell script (mgnuc), since `if_not_there.c'
> > 	uses exec() and the MinGW exec() of course doesn't handle
> > 	Bourne shell scripts.
...
> >  mark_rts.o: $(srcdir)/mark_rts.c $(UTILS)
> >  	rm -f mark_rts.o
> >  	-./if_mach ALPHA OSF1 $(CC) -c $(CFLAGS) -Wo,-notail $(srcdir)/mark_rts.c
> > -	./if_not_there mark_rts.o $(CC) -c $(CFLAGS) $(srcdir)/mark_rts.c
> > +	-./if_not_there mark_rts.o $(CC) -c $(CFLAGS) $(srcdir)/mark_rts.c
> > +	./if_not_there mark_rts.o `cygpath -w /bin/sh` $(CC) -c $(CFLAGS) $(srcdir)/mark_rts.c
> >  #	Work-around for DEC optimizer tail recursion elimination bug.
> >  #  The ALPHA-specific line should be removed if gcc is used.
>
> I am not sure that this change will work on a non MinGW system, if you
> have tested it and it doesn't cause any problems then commit away.

It works fine on Linux.  I've committed it.

It might perhaps cause problems on systems where the object file
extension is not `.o', but I think there are probably lots of other
things in the same Makefile that would also cause problems for such
systems.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
                                    |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list