[m-rev.] diff: fix bug in boehm_gc/Makefile

Fergus Henderson fjh at cs.mu.OZ.AU
Thu Apr 12 00:19:47 AEST 2001


Estimated hours taken: 0.75
Branches: main

boehm_gc/Makefile:
	Fix a bug in my previous change: use "env MERCURY_C_INCL_DIR=."
	rather than to just "MERCURY_C_INCL_DIR=." in $(CC).
	This is needed since $(CC) needs to be a program, not a shell
	script, since it is invoked via if_not_there, and if_not_there.c
	uses execvp() rather than system().
	("env" is a standard Unix program, which normally lives in /usr/bin.
	See "man env" for details.)

Workspace: /mnt/hg/home/hg/fjh/ws-hg3/mercury
Index: boehm_gc/Makefile
===================================================================
RCS file: /home/mercury1/repository/mercury/boehm_gc/Makefile,v
retrieving revision 1.46
diff -u -d -r1.46 Makefile
--- boehm_gc/Makefile	2001/04/11 00:04:47	1.46
+++ boehm_gc/Makefile	2001/04/11 14:17:49
@@ -33,8 +33,13 @@
 ABI_FLAG= 
 # CC=cc $(ABI_FLAG)
 
-# Mercury-specific definition of CC:
-CC=MERCURY_C_INCL_DIR=. ../scripts/mgnuc --grade $(GRADE) --no-ansi --no-check
+# Mercury-specific definition of CC.
+# Note that we need to use "env FOO=bar ..." here, rather than just
+# "FOO=bar ...", since $(CC) needs to be a program, not a shell script,
+# because it is invoked via if_not_there, and if_not_there.c uses execvp()
+# rather than system().
+# ("env" is a standard Unix program, which normally lives in /usr/bin).
+CC=env MERCURY_C_INCL_DIR=. ../scripts/mgnuc --grade $(GRADE) --no-ansi --no-check
 
 CXX=g++ $(ABI_FLAG)
 # Needed only for "make c++", which adds the c++ interface

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
                                    |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list