[m-rev.] Re: for review: MinGW portability fixes

Peter Ross peter.ross at miscrit.be
Sat Apr 7 19:31:57 AEST 2001


On Sat, Apr 07, 2001 at 07:14:29PM +1000, Fergus Henderson wrote:
> BTW, for the diff I just posted, I forgot to mention which branch(es):
> 
> 	Branches: main, release
> 
> Also, I realized that this change
> 
> On 07-Apr-2001, Fergus Henderson <fjh at cs.mu.oz.au> wrote:
> > 
> > compiler/modules.m:
> > 	If renaming the `tmp_d' file doesn't work,
> > 	try again after removing the `.d' file.
> > 	This is needed since on MinGW, io__rename_file
> > 	(i.e. rename()) won't remove the target if it already exists.
> > 	Note that the behaviour of io__rename_file is explicitly
> > 	documented as being implementation-dependent in this situation,
> > 	so we need to handle this case here.
> 
> makes some of the code in library/io.m unnecessary now.
> So here's another diff (just for the main branch this time).
> For review by Peter Ross.
> 
> ----------
> 
> Estimated hours taken: 0.25
> Branches: main
> 
> library/io.m:
> 	Delete some MSVC-specific stuff that isn't needed.
> 
Both diffs look fine.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list