[m-dev.] Even more minimal diff

Fergus Henderson fjh at cs.mu.OZ.AU
Thu Oct 3 14:18:25 AEST 2002

On 03-Oct-2002, Michael Day <mikeday at yeslogic.com> wrote:
> Here is a diff that just adds make_io_error to io.m, which should be 
> enough to allow the general cleaning up of stream.m.

That looks good.  A few small points:

(1) Please include a proposed CVS log message when posting diffs.
(2) The diff is reversed (you should use `diff old new', not `diff new old').
(3) The new function should be mentioned in the NEWS file.
(4) The comment "(This is necessary for stream implementations)."
    is probably better put in the log message than in the source file.
    In general it's fine to put design rationale in the source file,
    but in this case, I think the comment would just be confusing
    for users, because of the lack of appropriate context.
    Anyway, the function is useful for things other than stream
    implementations; it's needed for any code that wants to make use
    of the type io__result and can fail for reasons of its own making.
    So I suggest either deleting that comment, or replacing it with
    something more general.

It would be great if you could post a diff which addressed these points.

Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au

More information about the developers mailing list