[m-dev.] for review: changes to MLDS

[Fergus Henderson]

On 01-Feb-2001, Julien Fischer <juliensf at students.cs.mu.oz.au> wrote:
> Here is the relative diff again (with -h this time) 
> 
> diff -u compiler/ml_code_util.m compiler/ml_code_util.m
> --- compiler/ml_code_util.m
> +++ compiler/ml_code_util.m
> @@ -245,7 +245,6 @@
>  
>  	% Generate declaration flags for a local variable
>  	%
> -	%
>  :- func ml_gen_local_var_decl_flags = mlds__decl_flags.
>  	
>  	% Generate declaration flags for a public field
> @@ -1569,6 +1568,10 @@
>  	{ ml_skip_dummy_argument_types(OutputVarTypes0, OutputVarLvals0,
>  		OutputVarTypes, OutputVarLvals) },
>  	list__map_foldl(ml_gen_type, OutputVarTypes, MLDS_OutputVarTypes),
> +	%
> +	% We expect OutputVarlvals0 OutputVarTypes0 to be empty if
> +	% `--nondet-copy-out' is not enabled.

s/OutputVarlvals0 OutputVarTypes0/
  OutputVarlvals0 and OutputVarTypes0/
                  ^^^

> +++ compiler/mlds.m
> @@ -550,10 +550,11 @@
>  	;	mlds__rtti_type(rtti_name)
>  
>  		% A type used internally by the ML code generator to 
> +		% for references to variables that have yet to be
> +		% declared.  This occurs once in ml_code_util.m where
> +		% references to env_ptr's are generated but the declaration
> +		% of these env_ptr's does not occur until the ml_elim_nested
> +		% pass.
>  	;	mlds__unknown_type.

That's still misleading.  Saying "A type used internally by the ML code
generator" implies that when the ML code generator is finished, there
will be no occurences of that type.  But currently that's not the case.

also s/to for references/for references/

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
                                    |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------