[m-dev.] for review:

[Fergus Henderson]

On 18-Sep-2000, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> Unify the code that performs the three kinds of data movements
> required for calls:

That change looks good.  It's the kind of thing that needs careful
testing, but assuming it works it will be a significant improvement.

...
> +++ compiler/arg_info.m	2000/09/06 11:34:03
> +% XXX END
> +
> +:- pred arg_info__input_args(list(arg_info)::in, list(arg_loc)::out) is det.
> +
> +arg_info__input_args([], []).
> +arg_info__input_args([arg_info(Loc, Mode) | Args], Vs) :-
> +	arg_info__input_args(Args, Vs0),
> +	( Mode = top_in ->
> +		Vs = [Loc | Vs0]
> +	;
> +		Vs = Vs0
> +	).

What's the "XXX END" comment here for?

> diff -u -r1.252 code_info.m
> +code_info__setup_call(GoalInfo, ArgInfos, LiveLocs, Code) -->
> +	{ partition_args(ArgInfos, InArgInfos, OutArgInfos, _UnusedArgInfos) },
> +	{ assoc_list__keys(OutArgInfos, OutVars) },
> +	{ set__list_to_set(OutVars, OutVarSet) },
> +	code_info__compute_forward_live_var_saves(OutVarSet, ForwardVarLocs),
> +
> +	{ goal_info_get_code_model(GoalInfo, CodeModel) },
> +	( { CodeModel = model_non } ->
> +			% Save variables protected by the nearest resumption
> +			% point on the stack. XXX
> +		code_info__compute_resume_var_stack_locs(ResumeVarLocs),
> +		{ list__append(ResumeVarLocs, ForwardVarLocs, StackVarLocs) }
> +	;
> +		{ StackVarLocs = ForwardVarLocs }
> +	),

What's the "XXX" comment here for?

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------