[m-dev.] for review: use caller context in GUD

Peter Ross petdr at cs.mu.OZ.AU
Wed Jan 12 20:38:03 AEDT 2000


Hi,

For Fergus to review.

2:      2  2 CALL pred io:read_line/3-0 (det) c5;t; io.m:123 (foo.m:456)

>From what I can gather, the intended meaning for which line is displayed
by the GUD, is to display the context of where the call is called from
'(foo.m:456)' *rather* then the body of the call 'io.m:123'.

Personally this is the behaviour I prefer, of course what would be
preferable is if there was a variable that could be set which would
decide which context to use, however that is beyond my elisp coding
skills.

===================================================================


Estimated hours taken: 1

mercury/scripts/gud.el:
    Fix a bug the that the caller context was being obtained from the
    wrong part of the line.


Index: gud.el
===================================================================
RCS file: /home/staff/zs/imp/mercury/scripts/gud.el,v
retrieving revision 1.5
diff -u -r1.5 gud.el
--- gud.el	1999/11/18 17:27:14	1.5
+++ gud.el	2000/01/12 08:46:00
@@ -1146,12 +1146,12 @@
 	    (let
 		((msg (substring result (match-beginning 1) (match-end 1)))
 		 ;; match 2 is for the optional path
-		 (caller-file
+		 (file
 		   (substring result (match-beginning 3) (match-end 3)))
-		 (caller-line
+		 (line
 		   (substring result (match-beginning 4) (match-end 4)))
-		 (file (substring result (match-beginning 5) (match-end 5)))
-		 (line (substring result (match-beginning 6) (match-end 6))))
+		 (caller-file (substring result (match-beginning 5) (match-end 5)))
+		 (caller-line (substring result (match-beginning 6) (match-end 6))))
 	      (message "%s" msg)
               (save-excursion
                 (let ((abs-caller-file (gud-mdb-file-name caller-file))

----
Peter Ross
PhD Student University of Melbourne
http://www.cs.mu.oz.au/~petdr/
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------



More information about the developers mailing list