[m-dev.] for review: bug fix for existential_rtti.m

Fergus Henderson fjh at cs.mu.OZ.AU
Tue Feb 15 19:03:33 AEDT 2000


On 15-Feb-2000, David Glen JEFFERY <dgj at cs.mu.OZ.AU> wrote:
> Estimated hours taken: 8 
> 		(including a few misguided tries...)
> 
> compiler/type_util.m:
> 	Add a new predicate, type_util__real_vars, which is the same
> 	as type_util__vars except it doesn't count type-info variables.
> compiler/{continuation_info.m, hlds_pred.m, trace.m}:
> 	Use type_util__real_vars rather than type_util__vars since the
> 	latter was causing problems when calculating the live type-infos,
> 	and causing the failure of the test case 
> 	tests/hard_coded/existential_rtti.m in debug grade.

All your changes look fine.

The only thing I'm concerned about is that there
may be some additional places which should be changed
to use type_util__real_vars rather than type_util__vars
or term__vars_list (or term__contains_var).

But at very least your change is an improvement on the
status quo, so go ahead and commit it.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------



More information about the developers mailing list