[m-dev.] for review: fix unsafe_type_cast for MLDS back-end

Fergus Henderson fjh at cs.mu.OZ.AU
Thu Dec 14 13:03:42 AEDT 2000


On 14-Dec-2000, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
>  
> Fergus wrote:
> > library/private_builtin.m:
> > 	Delete the `:- external' declaration for unsafe_type_cast;
> > 	this is not needed, and could cause problems because it
> > 	suppresses the definition for unsafe_type_cast,
> > 	which could cause problems if you take its address.
> 
> This change didn't appear in the diff.

Oops -- that was because I had accidentally committed it (with the MLDS
trailing changes) before I made the diff!  I've undone that commit.

I'll recommit it with the right log message, along with the rest of
the unsafe_type_cast changes.

The diff is below.

Index: private_builtin.m
===================================================================
RCS file: /home/mercury1/repository/mercury/library/private_builtin.m,v
retrieving revision 1.60
diff -u -d -u -r1.60 private_builtin.m
--- private_builtin.m	2000/12/14 02:00:05	1.60
+++ private_builtin.m	2000/12/14 02:00:27
@@ -594,7 +594,7 @@
 
 :- implementation.
 
-:- external(unsafe_type_cast/2).
+% unsafe_type_cast is a builtin; the compiler generates inline code for it
 
 unused :-
 	( semidet_succeed ->

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
                                    |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------



More information about the developers mailing list