[m-dev.] for review: trailing for the MLDS back-end

[Fergus Henderson]

On 12-Dec-2000, Robert Jeschofnik <rejj at students.cs.mu.oz.au> wrote:
> > +% As we traverse the goal, we add new variables
> > +% keep track of XXX
> > +% construct it.
> > +%
> 
> This comment doesn't make much sense, perhaps it is incomplete?

Oops, yes.  Sorry about that, and thanks for pointing it out.
I've changed it to the following:

%
% As we traverse the goal, we add new variables to hold the
% trail tickets (i.e. saved values of the trail pointer)
% and the saved values of the trail ticket counter.
% So we need to thread a varset and a vartypes mapping through,
% to record the names and types of the new variables.
%
% We also keep the module_info around, so that we can use
% the predicate table that it contains to lookup the pred_ids
% for the builtin procedures that we insert calls to.
% We do not update the module_info as we're traversing the goal.
%

:- type trail_ops_info --->
        trail_ops_info(
                varset :: prog_varset,
                var_types :: vartypes,
                module_info :: module_info
        ).

> > +	% For documentation, see the corresponding LLDS 
> 
> same here

That one should be

	% For documentation, see the corresponding LLDS instructions
	% in compiler/llds.m.  See also compiler/notes/trailing.html.

There's also a fair few other changes that turned out to be needed;
I'll post another diff when I've tested it a bit more.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
                                    |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------