[m-dev.] Re: for review: add MR_ to Word, Integer, String, etc...

[Tyson Dowd]

On 01-Aug-2000, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > Index: runtime/mercury.h
> >  /*
> > -** The following types are used to represent the Mercury builtin types.
> > -** See mercury_types.h and mercury_float.h.
> > -*/
> > -typedef Char	MR_Char;
> > -typedef Float	MR_Float;
> > -typedef Integer	MR_Integer;
> > -typedef String	MR_String;
> > -typedef ConstString MR_ConstString;
> 
> I think it would be nicer to change that to a comment:
> 
> 	/*
> 	** The types uses to represent the Mercury builtin types,
> 	** MR_Char, MR_Float, MR_Integer, MR_String, and MR_ConstString,
> 	** are defined in mercury_types.h and mercury_float.h.
> 	*/

Done.

>   /*
>   ** The MR_Word type, which is used for representing user-defined
>   ** types when we're using the low-level data representation,
>   ** is defined in runtime/mercury_types.h.
>   */

Also done.

> > -/*
> > -** The MR_Box type is used for representing polymorphic types.
> > -*/
> > -typedef void 	*MR_Box;
> 
> Why was this removed from runtime/mercury.h?

Because it isn't currently defined in the LLDS backend.  I want to use
this type to represent polymorphic types and c_pointer if interfacing to
C (in other words, I want export.m to be able to generate MR_Box and it
will work in all backends).  This should be mentioned in the log
message, and I will add a comment like the other ones to say where to
look for it.

> >  /*
> > -** Code to box/unbox floats
> > +** MR_Code to box/unbox floats
> 
> That was a false hit.  It should be "Code", not "MR_Code".

There were a few of these.  They are fixed.

-- 
       Tyson Dowd           # 
                            #  Surreal humour isn't everyone's cup of fur.
     trd at cs.mu.oz.au        # 
http://www.cs.mu.oz.au/~trd #
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------