[m-dev.] for review: cleanup of grade handling

Fergus Henderson fjh at cs.mu.OZ.AU
Thu Nov 4 19:05:46 AEDT 1999


On 04-Nov-1999, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> 
> Index: scripts/mgnuc.in
...
> -	--low-level-debug
> -	-g, --c-debug
> -	--no-c-optimize
> -	--use-trail
> -	--pic-reg
> -	--inline-alloc
> -	--split-c-files
> -		See the documentation in the \"Invocation\" section
> -		of the Mercury User's Guide.
...
> +	--low-level-debug
> +		Enable low-level debugging of the C code. Useful only
> +		for Mercury system developers.
> +	-g, --c-debug
> +		Generate object files that can debugged with C debuggers
> +		such as gdb.
> +	--no-c-optimize
> +		Disable optimization by the C compiler.
> +	--inline-alloc
> +		Inline calls to the memory allocator.
> +	--split-c-files
> +		Must be specified if the argument C files were generated
> +		by the Mercury compiler with --split-c-files.

s/Must be/This option must be/

For most of those options, particularly the --split-c-files,
--inline-alloc, and --c-debug options and also to some extent the
--low-level-debug option, the documentation in the Mercury User's guide
is more detailed.  So I suggest you either copy the documentation from
the Mercury User's Guide here, or append "See the documentation in the
\"Invocation\" section of the Mercury User's Guide." after each such
option's documentation.

scripts/ml.in:
> -# --require-tracing (which is implied by --debug) implies --trace
> +# --debug implies --trace
>  case $require_tracing in
>  	true)	trace=true ;;
>  	false)	;;

Hmm, I think the original comment is clearer.

> +case $picreg in
> +	true)	GRADE="$GRADE.picreg" ;;
> +	false)	;;
> +esac

I think that is wrong; I think picreg is not supposed to be
part of the grade string used in the library name.

Apart from that, this change looks good.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------



More information about the developers mailing list