[m-dev.] Re: your mail

[Erwan Jahier]

| On 10-Feb-1999, Erwan Jahier <Erwan.Jahier at irisa.fr> wrote:
| > +				if (message == NULL)
| > +				{
| 
| The `{' should be on the same line as the `if'.
| 
| > +				} else {
| > +					MR_send_message_to_socket_format(
| > +						"\"error(%s)\".\n", message);
| > +				}
| 
| I think the quotes are in the wrong place there.
| You want to send `error("...")' rather than
| `"error(...)"', don't you?

Yes. I've just noticed that.

| 
| So I think it should be
| 
| 					MR_send_message_to_socket_format(
| 						"error(\"%s\").\n", message);

Yes.

| 
| > -			MR_trace_retry(layout, saved_regs, event_details,
| > +			message = MR_trace_retry(layout, saved_regs, event_details,
| >  				seqno, depth, max_mr_num, jumpaddr);
| > +			fflush(MR_mdb_out);
| > +			fprintf(MR_mdb_err, message);
| > +			fprintf(MR_mdb_err, "\n");
| 
| That should be
| 
| 			fprintf(MR_mdb_err, "%s\n", message);
| 
| Otherwise you will run into problems if the message
| contains a "%".

OK. 


| Apart from those things, your change looks fine.

So I will commit it.
Thanks Fergus.


-- 
R1.