[m-dev.] for review: Aditi [5]

[Simon Taylor]

Thanks for your review Fergus.

> 
> On 07-Jul-1998, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> magic.m:
> > % This should attempt to reorder within rules so that no supplementary
> > % predicates are created with partially instantiated arguments, since Aditi
> > % can only handle ground terms in relations. The problem occurs if there are
> > % partially instantiated terms live across a database predicate call. At the
> > % moment an error is reported.
> 
> Should that comment have an "XXX"?

Probably.

> > 		{ string__format("%s__aditi%i",
> > 			[s(Name), i(ProcInt)], NewName) }
> > 	),
> 
> Perhaps you should use make_pred_name_with_context
> defined in prog_util.m.

Yes, that might look a little nicer.

> You should modify the demanglers (util/mdemangle.c
> and profiler/demangle.m) to handle the new names.

None of the new names will show up in the generated C code, so that
isn't necessary. I'll add a comment somewhere.

Simon.